Initial driver-kotlin-sync implementation #1090
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rozza
force-pushed
the
JAVA-4869
branch
2 times, most recently
from
f73dbb6 to
c7b32d2
Compare
Wraps the driver-sync to provide a kotlin sync API In general a faithful wrapping of the sync java driver. Uses reified overloads to provide synaptic sugar instead of passing resultClass. MongoIterable deviates from the sync API so to not implement Iterable in order to protect the user from leaving open cursors. In Kotlin there are two Iterable style implementations: Iterable and Sequence neither are auto closable. Sequence is more appropriate here as it lazily consumes the iterator, but it does not auto close. See: https://youtrack.jetbrains.com/issue/KT-34719 So MongoIterable provides a loan method that treats the cursor as a Sequence and automatically closes after use. JAVA-4869
rozza
commented
Feb 20, 2023
driver-kotlin-sync/src/integration/kotlin/com/mongodb/kotlin/client/CrudTest.kt
Outdated
Show resolved
Hide resolved
driver-kotlin-sync/src/main/kotlin/com/mongodb/kotlin/client/MongoIterable.kt
Show resolved
Hide resolved
driver-kotlin-sync/src/main/kotlin/com/mongodb/kotlin/client/MongoIterable.kt
Show resolved
Hide resolved
driver-kotlin-sync/src/main/kotlin/com/mongodb/kotlin/client/MongoIterable.kt
Outdated
Show resolved
Hide resolved
driver-kotlin-sync/src/test/kotlin/com/mongodb/kotlin/client/AggregateIterableTest.kt
Show resolved
Hide resolved
driver-kotlin-sync/src/test/kotlin/com/mongodb/kotlin/client/AggregateIterableTest.kt
Show resolved
Hide resolved
Also updates noticed when working with the coroutine api
jyemin
requested changes
Feb 27, 2023
Collaborator
jyemin
left a comment
jyemin
left a comment
There was a problem hiding this comment.
Gave it a good first look.
driver-kotlin-sync/src/main/kotlin/com/mongodb/kotlin/client/ClientSession.kt
Outdated
Show resolved
Hide resolved
driver-kotlin-sync/src/main/kotlin/com/mongodb/kotlin/client/MongoIterable.kt
Show resolved
Hide resolved
driver-kotlin-sync/src/main/kotlin/com/mongodb/kotlin/client/MongoIterable.kt
Show resolved
Hide resolved
driver-kotlin-sync/src/main/kotlin/com/mongodb/kotlin/client/MongoClient.kt
Outdated
Show resolved
Hide resolved
driver-kotlin-sync/src/main/kotlin/com/mongodb/kotlin/client/MongoChangeStreamCursor.kt
Outdated
Show resolved
Hide resolved
jyemin
requested changes
Feb 28, 2023
driver-kotlin-sync/src/integration/kotlin/com/mongodb/kotlin/client/UnifiedCrudTest.kt
Show resolved
Hide resolved
1 task
katcharov
reviewed
Mar 4, 2023
Collaborator
katcharov
left a comment
katcharov
left a comment
There was a problem hiding this comment.
I looked over the wrappers, looked good, and nice straightforward handling of the default parameters. A few minor comments related to the tests.
driver-kotlin-sync/src/test/kotlin/com/mongodb/kotlin/client/ListDatabasesIterableTest.kt
Show resolved
Hide resolved
driver-kotlin-sync/src/test/kotlin/com/mongodb/kotlin/client/ListDatabasesIterableTest.kt
Show resolved
Hide resolved
driver-kotlin-sync/src/test/kotlin/com/mongodb/kotlin/client/MongoChangeStreamCursorTest.kt
Show resolved
Hide resolved
driver-kotlin-sync/src/test/kotlin/com/mongodb/kotlin/client/MongoClientTest.kt
Show resolved
Hide resolved
driver-kotlin-sync/src/test/kotlin/com/mongodb/kotlin/client/MongoClientTest.kt
Outdated
Show resolved
Hide resolved
zigzago
reviewed
Mar 8, 2023
driver-kotlin-sync/src/main/kotlin/com/mongodb/kotlin/client/MongoClient.kt
Show resolved
Hide resolved
driver-kotlin-sync/src/main/kotlin/com/mongodb/kotlin/client/MongoClient.kt
Outdated
Show resolved
Hide resolved
driver-kotlin-sync/src/main/kotlin/com/mongodb/kotlin/client/MongoIterable.kt
Show resolved
Hide resolved
driver-kotlin-sync/src/main/kotlin/com/mongodb/kotlin/client/AggregateIterable.kt
Show resolved
Hide resolved
driver-kotlin-sync/src/main/kotlin/com/mongodb/kotlin/client/MongoCollection.kt
Outdated
Show resolved
Hide resolved
driver-kotlin-sync/src/main/kotlin/com/mongodb/kotlin/client/AggregateIterable.kt
Show resolved
Hide resolved
|
For some reason I can not resolve my own comments, but the PR is ok for me |
zigzago
approved these changes
Mar 8, 2023
…unctions that return the same result when the object state remains the same
jyemin
requested changes
Mar 15, 2023
driver-kotlin-sync/src/main/kotlin/com/mongodb/kotlin/client/AggregateIterable.kt
Show resolved
Hide resolved
driver-kotlin-sync/src/main/kotlin/com/mongodb/kotlin/client/MongoCursor.kt
Outdated
Show resolved
Hide resolved
driver-kotlin-sync/src/main/kotlin/com/mongodb/kotlin/client/MongoClient.kt
Show resolved
Hide resolved
driver-kotlin-sync/src/main/kotlin/com/mongodb/kotlin/client/AggregateIterable.kt
Outdated
Show resolved
Hide resolved
jyemin
reviewed
Mar 17, 2023
driver-kotlin-sync/src/main/kotlin/com/mongodb/kotlin/client/MongoCursor.kt
Outdated
Show resolved
Hide resolved
Member
Author
|
Will manually rebase and squash |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wraps the driver-sync to provide a kotlin sync API
In general a faithful wrapping of the sync java driver. Uses reified overloads to provide syntactic sugar instead of passing resultClass.
MongoIterable deviates from the sync API so to not implement Iterable in order to protect the user from leaving open cursors. In Kotlin there are two Iterable style implementations: Iterable and Sequence neither are auto closable. Sequence is more appropriate here as it lazily consumes the iterator, but it does not auto close. See: https://youtrack.jetbrains.com/issue/KT-34719 So MongoIterable provides a loan method that treats the cursor as a Sequence and automatically closes after use.
JAVA-4869
Todo
maxTime(maxTime: Long, timeUnit: TimeUnit = TimeUnit.MILLISECONDS)MongoIterablethe correct name?com.mongodb.kotlin.client